Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

supporting local model for jupyter-ai with ollama #868

Closed
wants to merge 3 commits into from
Closed

supporting local model for jupyter-ai with ollama #868

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b2755c
add Ollama, support "gemma","gemma2","llama2","llama3","phi3","mistra…
Jul 2, 2024
597b325
Merge remote-tracking branch 'origin/main'
Jul 2, 2024
566c686
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[pre-commit.ci] auto fixes from pre-commit.com hooks 
for more information, see https://pre-commit.ci
  • Loading branch information
@pre-commit-ci
pre-commit-ci[bot] committed Jul 2, 2024
commit 566c6868c245d14655a2f4f6a624d5c6cd9004dd
2 changes: 1 addition & 1 deletion packages/jupyter-ai-magics/jupyter_ai_magics/providers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,7 +730,6 @@ async def _acall(self, *args, **kwargs) -> Coroutine[Any, Any, str]:
return await self._call_in_executor(*args, **kwargs)



class OllamaProvider(BaseProvider, Ollama):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see a similar implementation in PR #646 with a much simpler class and see if all the functions defined in your file from line 760 onwards are necessary, or being called to produce the response.

id = "ollama"
name = "Ollama"
Expand Down Expand Up @@ -808,6 +807,7 @@ def _call(self, prompt: str = None, messages: list = None, **kwargs) -> str:
else:
raise ValueError("Either 'prompt' or 'messages' must be provided.")


class JsonContentHandler(LLMContentHandler):
content_type = "application/json"
accepts = "application/json"
Expand Down
Loading