Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address error on /learn after change of embedding model #870

Merged
merged 4 commits into from
Jul 8, 2024
Merged

Address error on /learn after change of embedding model #870

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
42df218
Address error on `/learn` after change of embedding model.
srdas Jul 3, 2024
98b6600
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 3, 2024
502442e
Set `all_files` option to default to False
srdas Jul 5, 2024
7a1f4f0
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Address error on /learn after change of embedding model.
  • Loading branch information
@srdas
srdas committed Jul 8, 2024
commit 42df2184a1dbc7ab6eef3797a64c465c5568e801
2 changes: 1 addition & 1 deletion packages/jupyter-ai/jupyter_ai/chat_handlers/learn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ async def relearn(self, metadata: IndexMetadata):
for dir in metadata.dirs:
# TODO: do not relearn directories in serial, but instead
# concurrently or in parallel
await self.learn_dir(dir.path, dir.chunk_size, dir.chunk_overlap)
await self.learn_dir(dir.path, dir.chunk_size, dir.chunk_overlap, all_files=False)

self.save()

Expand Down