Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support to index py, ipynb, md, and R files #89

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Added support to index py, ipynb, md, and R files #89

merged 1 commit into from
Apr 18, 2023

Conversation

3coins
Copy link
Collaborator

@3coins 3coins commented Apr 18, 2023

Added an updated loader that supports an expanded glob pattern to enable indexing for py, ipynb, md, and R files.

@3coins 3coins self-assigned this Apr 18, 2023
@3coins 3coins added the enhancement New feature or request label Apr 18, 2023
@3coins 3coins added this to the Milestone 3 milestone Apr 18, 2023
@3coins 3coins marked this pull request as ready for review April 18, 2023 13:47
ellisonbg
ellisonbg approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@ellisonbg ellisonbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I am going to merge and then iterate on this. I think we can simplify the logic and use Dask/Ray to accelerate the indexing of a directory.

@ellisonbg ellisonbg merged commit 4393367 into jupyterlab:main Apr 18, 2023
@3coins 3coins deleted the add-file-support branch May 5, 2023 18:42
dbelgrod pushed a commit to dbelgrod/jupyter-ai that referenced this pull request Jun 10, 2024
@3coins
Added support to index py, ipynb, md, and R files (jupyterlab#89)
538b753
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellisonbg ellisonbg ellisonbg approved these changes

Assignees

@3coins 3coins

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.8.0 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@3coins @ellisonbg