Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PRS-4560 Compiling dist folder #15

Merged
merged 1 commit into from
Feb 19, 2018
Merged

PRS-4560 Compiling dist folder #15

merged 1 commit into from
Feb 19, 2018

Conversation

kymmeh
Copy link
Contributor

@kymmeh kymmeh commented Feb 19, 2018

Changed

  • Compiled dist folder for publication

@kymmeh kymmeh requested a review from a team as a code owner February 19, 2018 17:50
@DamianMullins
Copy link
Contributor

Did the preparetask not run before the publish?

@DamianMullins DamianMullins merged commit 65071d0 into master Feb 19, 2018
@DamianMullins DamianMullins deleted the PRS-4560_publishing-dist branch February 19, 2018 21:08
@ashleynolan
Copy link

@DamianMullins Is this likely to keep happening? Seems a bit flakey – not sure if there's a way of making sure this can't happen before publishing…

@DamianMullins
Copy link
Contributor

DamianMullins commented Feb 20, 2018 •
edited
Loading

It's an issue with Yarn, when you pubish with npm it deploys fine. It seems that Yarn don't support some/all of the lifecycle hook scripts. There is a bit more info in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DamianMullins DamianMullins DamianMullins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kymmeh @DamianMullins @ashleynolan