fix(default-replacer): `(?:\.(js|json)$)` should be replaced by `(?:\\.(js|json)$)` #131

izumiya · 2022-07-16T20:05:28Z

This PR solves the following problem.

console.log(`(?:\.(js|json)$)`); // results (?:.(js|json)$).

This expression would match "{any character}js" or "{any character}json" when it is expected to match ".js" or ".json" .
If the file name ends with "-json.js", the import will fail as in the attached test project22.

…\.(js|json)$)`

fix(default-replacer): (?:\.(js|json)$) should be replaced by `(?:\…

3850baf

…\.(js|json)$)`

izumiya force-pushed the bugfix/regex branch from 27c1001 to 3850baf Compare July 17, 2022 01:26

izumiya changed the title ~~fix(default-replacer): (?:\.(js|json)$) should be (?:\\.(js|json)$)~~ fix(default-replacer): (?:\.(js|json)$) should be replaced by (?:\\.(js|json)$) Jul 17, 2022

justkey007 closed this Jul 18, 2022

justkey007 reopened this Jul 18, 2022

justkey007 merged commit a6e465f into justkey007:master Jul 18, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(default-replacer): `(?:\.(js|json)$)` should be replaced by `(?:\\.(js|json)$)` #131

fix(default-replacer): `(?:\.(js|json)$)` should be replaced by `(?:\\.(js|json)$)` #131

izumiya commented Jul 16, 2022

fix(default-replacer): (?:\.(js|json)$) should be replaced by (?:\\.(js|json)$) #131

fix(default-replacer): (?:\.(js|json)$) should be replaced by (?:\\.(js|json)$) #131

Conversation

izumiya commented Jul 16, 2022

fix(default-replacer): `(?:\.(js|json)$)` should be replaced by `(?:\\.(js|json)$)` #131

fix(default-replacer): `(?:\.(js|json)$)` should be replaced by `(?:\\.(js|json)$)` #131