Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SASS): Allow import scss files from lib or dependencies #100

Merged
merged 1 commit into from
May 27, 2017

Conversation

rtrompier
Copy link
Contributor

@rtrompier rtrompier commented May 20, 2017

This feature allow the developer to import other SCSS files into the scss component file.

Eg :
From node_modules dependencies : @import '~angular/material/theming';
From other component : @import '../other-component/other-component.component.scss';

Copy link

@paesku paesku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally and it works like a charme.
IMO this request should be accepted, since it's such an important part when building libraries and sharing settings, functions and mixins via scss files.

@jvandemo
Copy link
Owner

@rtrompier — Thank you, this works great! 👍

Would you be able to add a section to the README so I can merge this?

Thanks in advance!

@jvandemo jvandemo merged commit 6549afa into jvandemo:master May 27, 2017
@jvandemo
Copy link
Owner

@rtrompier — I have added the documentation and released your changes as v10.2.0.

Thank you for your contribution! 👍

@sgentile
Copy link

Question: @rtrompier - where inside the generator code would I put a global .scss file in which to import my styles - I have several components and want to have it used for them all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants