Add support for skipping blank lines #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a CSV file begins with a blank line (before the header), the EasyCSV library will bomb. This is because fgetcsv() returns an array with a single item (with a value of null) when it encounters a blank line. So, in a case where the 1st line is blank, the header row get set to a one-item array. When the 1st real line of data is read (the header row), the array size of the row will not match the single-item array size of $this->_headers, and we get an error.
Change the default value for $skipBlanks to ensure backwards compatibility.
|
The test suite wouldn't run for me and I didn't have a change to track down why, so I have not added a test for the new functionality yet, nor have I been able to run a regression test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.