Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Pramp, a platform to practice interviews #242

Merged
merged 1 commit into from
Sep 13, 2017

Conversation

meshuamam
Copy link
Contributor

  • Added in English, Hebrew and where minor translations weren't made (Arabic, Spanish, French, etc.)
  • Fixed a typo in Hebrew in the word 'search'
  • Fixed link to Interview Process & General Interview Prep in Hebrew

@jwasham
Copy link
Owner

jwasham commented Sep 4, 2017

Thanks. Pramp is already included in the mock interviews section.

@meshuamam
Copy link
Contributor Author

@jwasham Thanks, I totally missed it.
I fixed the duplication, moved it to the right places in some languages, and added the relevant Hebrew translation.

@jwasham
Copy link
Owner

jwasham commented Sep 6, 2017

Please remove referral codes.

@meshuamam
Copy link
Contributor Author

meshuamam commented Sep 6, 2017 via email

@meshuamam
Copy link
Contributor Author

@jwasham is that ok with you or would you like me to remove them?

@jwasham
Copy link
Owner

jwasham commented Sep 9, 2017

Yes, please remove them. I'd suggest looking at referrers in Google analytics for this case.

I don't want to give the impression that this github project is a money-making venture.

* Fixed link to Interview Process & General Interview Prep in Hebrew
* Added Hebrew translations for coding challenges/mock interviews section.
@meshuamam
Copy link
Contributor Author

Removed everything but the translation fixes/additions.

@jwasham jwasham merged commit d99f5d4 into jwasham:master Sep 13, 2017
@jwasham
Copy link
Owner

jwasham commented Sep 13, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants