Qlecorre use byte array set 2 #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qlecorre
force-pushed
the
qlecorre-use-ByteArraySet-2
branch
from
b1c36af
to
0badc0e
Compare
eric-weaver
pushed a commit
that referenced
this pull request
Nov 17, 2020
* Use ByteArraySet * Simplified equals logic * Update MultiIndex * Update ByteArray * Revert ByteArraySet changes (#82) Co-authored-by: Quentin LeCorre <quentin@jwplayer.com> * Revert cache update changes * Addressed comments Co-authored-by: Quentin LeCorre <quentin@jwplayer.com> Co-authored-by: Eric Weaver <eweaver@jwplayer.com>
eric-weaver
pushed a commit
that referenced
this pull request
Nov 17, 2020
* Fix ByteArraySet chunk iterator BIG-4969 * Removed local debugging set-up * Use ByteArraySet * Addressed comments * Added test * Simplified equals logic * Move test resources to the right folder * Update MultiIndex * Update ByteArray * Compact test * Siplified testing * Remove the end-to-end test * Streamline import * Revert ByteArraySet changes (#82) Co-authored-by: Quentin LeCorre <quentin@jwplayer.com> * Simplifies test generation (#84) * cleanup data generation * Cleaner tests Co-authored-by: Eric Weaver <eweaver@jwplayer.com> Co-authored-by: Quentin LeCorre <quentin@jwplayer.com> * Simplifies asserts * Delete superfluous new line * Uses random seed * Revert cache update changes * Addressed comments * Removed superfluous test * Removing redundant for loop * Setting functions to private * Remove casting type on the right side * Switch methods to private * Addressed comments * Updates * Fixed failing tests * Adding logger * Better logging * Better logging * Added comments Co-authored-by: Quentin LeCorre <quentin@jwplayer.com> Co-authored-by: Eric Weaver <eweaver@jwplayer.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.