Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JDK 9+ module testing #364

Closed
lhazlewood opened this issue Jul 25, 2018 · 0 comments
Closed

JDK 9+ module testing #364

lhazlewood opened this issue Jul 25, 2018 · 0 comments
Assignees
@lhazlewood
Milestone
0.10.0

Comments

@lhazlewood
Copy link
Contributor

Certain tests in the api module use reflection and this fails on JDK 9+ due to the new Java Module system. Creating a core module that depends on api and impl might fix this. If so, we should do this before the 0.10 release since we don't want to introduce more than 1 release with module/dependency requirement changes.
@lhazlewood lhazlewood added this to the 0.10.0 milestone Jul 25, 2018
@lhazlewood lhazlewood self-assigned this Jul 30, 2018
lhazlewood added a commit that referenced this issue Jul 30, 2018
@lhazlewood
Enabled maven profile for JDK >= 9 that will add a surefire <argLine>…
4bf22c2 
… with '--add-opens java.base/jdk.internal.loader=ALL-UNNAMED' to ensure module reflection can occur during tests. Resolves #364
@lhazlewood lhazlewood mentioned this issue Jul 30, 2018
Merged
lhazlewood added a commit that referenced this issue Jul 30, 2018
@lhazlewood
Enabled maven profile for JDK >= 9 that will add a surefire <argLine>…
4a60b6c 
… with '--add-opens java.base/jdk.internal.loader=ALL-UNNAMED' to ensure module reflection can occur during tests. Resolves #364
lhazlewood added a commit that referenced this issue Jul 30, 2018
@lhazlewood
- Enabled maven profile for JDK >= 9 that will add a surefire <argLin…
3237b72 
…e> with '--add-opens java.base/jdk.internal.loader=ALL-UNNAMED' to ensure module reflection can occur during tests.

- Disabled travis openjdk11 and oraclejdk-ea builds - those build environments are not currently stable

Resolves #364
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lhazlewood lhazlewood

Labels
None yet
Projects
None yet
Milestone
0.10.0
Development

No branches or pull requests
1 participant
@lhazlewood