Switch to clover #251
Merged
Switch to clover #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dogeared
force-pushed
the
switch_to_clover
branch
3 times, most recently
from
b383911
to
84bf409
Compare
lhazlewood
reviewed
Sep 7, 2017
pom.xml
Outdated
| <plugin> | ||
| <groupId>org.eluder.coveralls</groupId> | ||
| <artifactId>coveralls-maven-plugin</artifactId> | ||
| <version>4.3.0</version> | ||
| <version>4.4.0-SNAPSHOT</version> |
There was a problem hiding this comment.
Given this is a snapshot version, will this prevent cutting a release (since snapshots are not allowed for releases?)
There was a problem hiding this comment.
Yep. It shouldn't be merged until (a) we either host the snapshot version somewhere (in the event the coveralls maven plugin folks drag their feet or (b) they release the 4.4.0 version of the plugin.
dogeared
force-pushed
the
switch_to_clover
branch
from
361f235
to
c10abec
Compare
dogeared
force-pushed
the
switch_to_clover
branch
from
c10abec
to
f4c3fa6
Compare
…improve coverage report.
… formally released.
dogeared
force-pushed
the
switch_to_clover
branch
from
f4c3fa6
to
15ac672
Compare
|
@lhazlewood Please review again. I've hosted the Once released, it will be a simple pom update to reference the official release version. |
|
LGTM! Feel free to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.travis.yml) to run tests with clover