Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a 'format' script to package.json #271

Closed
jwu910 opened this issue Oct 3, 2018 · 3 comments
Closed

Add a 'format' script to package.json #271

jwu910 opened this issue Oct 3, 2018 · 3 comments
Labels
first-timers-only Short and simple fixes I can walk a first-timer through. formatting This is ugly and needs fixing. good first issue Good for newcomers Hacktoberfest

Comments

@jwu910
Copy link
Owner

jwu910 commented Oct 3, 2018 •
edited
Loading

We should have a format script that could be called with npm run format to run prettier on the project source files.

Prettier and eslint are already setup. I am not 100% sure npm run lint:fix script will actually fix everything prettier will.
@jwu910 jwu910 changed the title Add a 'format Add a 'format' script to package.json Oct 3, 2018
@jwu910 jwu910 added good first issue Good for newcomers formatting This is ugly and needs fixing. Hacktoberfest first-timers-only Short and simple fixes I can walk a first-timer through. labels Oct 3, 2018
@DonaldLika
Copy link
Contributor

I can do it

@jwu910
Copy link
Owner Author

jwu910 commented Oct 3, 2018

Let me know if you have any trouble. I should have all the dependencies installed.

@VinayakBagaria VinayakBagaria mentioned this issue Oct 3, 2018
Closed
@DonaldLika DonaldLika mentioned this issue Oct 3, 2018
Merged
jwu910 pushed a commit that referenced this issue Oct 3, 2018
@DonaldLika @jwu910
CIO-271 Add format script with prettier on all js files (#273)
cc3d81a 
Fixes #271
@jwu910
Copy link
Owner Author

jwu910 commented Oct 3, 2018

Thanks @DonaldLika . Merged #273

@jwu910 jwu910 closed this as completed Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
first-timers-only Short and simple fixes I can walk a first-timer through. formatting This is ugly and needs fixing. good first issue Good for newcomers Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DonaldLika @jwu910