Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] Add Option and Change function signature of NewServer() #17

Merged
merged 2 commits into from
Oct 9, 2022

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Oct 9, 2022

No description provided.

@k1LoW k1LoW self-assigned this Oct 9, 2022
@k1LoW k1LoW changed the title Add Option and Change function signature of NewServer [BREAKING] Add Option and Change function signature of NewServer() Oct 9, 2022
@k1LoW k1LoW added the minor label Oct 9, 2022
@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2022

Code Metrics Report

main (e4bbd7a) #17 (ff55d9d) +/-
Coverage 81.2% 80.9% -0.3%
Code to Test Ratio 1:0.4 1:0.4 -0.0
Test Execution Time 18s 21s +3s
Details
  |                     | main (e4bbd7a) | #17 (ff55d9d) |  +/-  |
  |---------------------|----------------|---------------|-------|
- | Coverage            |          81.2% |         80.9% | -0.3% |
  |   Files             |              1 |             2 |    +1 |
  |   Lines             |            458 |           477 |   +19 |
+ |   Covered           |            372 |           386 |   +14 |
- | Code to Test Ratio  |          1:0.4 |         1:0.4 |  -0.0 |
  |   Code              |           1483 |          1518 |   +35 |
  |   Test              |            660 |           660 |     0 |
- | Test Execution Time |            18s |           21s |   +3s |

Code coverage of files in pull request scope (81.2% → 80.9%)

Files Coverage +/-
grpcstub.go 81.6% +0.4%
option.go 60.0% +60.0%

Reported by octocov

@k1LoW k1LoW merged commit 31e34b7 into main Oct 9, 2022
@k1LoW k1LoW deleted the option branch October 9, 2022 13:13
This was referenced Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant