Build arm64 with 64K page size #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should work on kernels with 64k pages, while also working on nodes with 4k or 16k page size. Ref: k3s-io/k3s#7335 Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
dereknola
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should work on kernels with 64k pages, while also working on nodes with 4k or 16k page size.
The switch from buildroot 2021.02.7 to 2022.08.1 in #54 added a configurable page size; unfortunately the default of 4k produces binaries that segfault on nodes with larger page sizes.
Ref: k3s-io/k3s#7335