Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-1.24] Enhance check-config #7165

Merged
merged 2 commits into from
Mar 29, 2023

Conversation

dereknola
Copy link
Member

@dereknola dereknola commented Mar 29, 2023

Proposed Changes

Backport:

Types of Changes

Verification

Run

Verification

  • Remove Iptables from a host
  • Install K3s
  • Run k3s check-config, validate that something like:
System:
- /var/lib/rancher/k3s/data/e41fb3fc61cae853bd497dcbe628059f2fd8f196745962a7bec3dec999149452/bin/aux iptables v1.8.8 (legacy): ok

Should shows up.

  • CONFIG_CGROUP_PIDS NETFILTER_XT_MATCH_COMMENT and NETFILTER_XT_MATCH_MULTIPORT are now under Generally Necessary:

Testing

Linked Issues

#7120
#7162

User-Facing Change


Further Comments

st3iny and others added 2 commits March 29, 2023 10:04
Add additional kernel config checks for NETFILTER_XT_MATCH_COMMENT and
NETFILTER_XT_MATCH_MULTIPORT as they are both required to run k3s.

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
* Move  CONFIG_CGROUP_PIDS to Required

Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola requested a review from a team as a code owner March 29, 2023 17:07
@dereknola dereknola merged commit 8995df0 into k3s-io:release-1.24 Mar 29, 2023
@dereknola dereknola deleted the check_config_124 branch April 28, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants