Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix e2e startup flaky test #7839

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

osodracnai
Copy link
Contributor

Proposed Changes

Add a eventually check to a flaky test

Types of Changes

Verification

Testing

Linked Issues

User-Facing Change


Further Comments

Signed-off-by: Ian Cardoso <osodracnai@gmail.com>
@osodracnai osodracnai requested a review from a team as a code owner June 30, 2023 17:47
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: +31.66 🎉

Comparison is base (0809187) 19.85% compared to head (34fd24a) 51.52%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7839       +/-   ##
===========================================
+ Coverage   19.85%   51.52%   +31.66%     
===========================================
  Files          83      143       +60     
  Lines        7686    14512     +6826     
===========================================
+ Hits         1526     7477     +5951     
+ Misses       5930     5848       -82     
- Partials      230     1187      +957     
Flag Coverage Δ
e2etests 49.35% <ø> (?)
inttests 44.58% <ø> (?)
unittests 19.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 118 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@manuelbuil manuelbuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am suffering from this

@dereknola dereknola merged commit 324f9ad into k3s-io:master Jul 3, 2023
osodracnai added a commit to osodracnai/k3s that referenced this pull request Jul 6, 2023
Signed-off-by: Ian Cardoso <osodracnai@gmail.com>
(cherry picked from commit 324f9ad)
osodracnai added a commit to osodracnai/k3s that referenced this pull request Jul 6, 2023
Signed-off-by: Ian Cardoso <osodracnai@gmail.com>
(cherry picked from commit 324f9ad)
osodracnai added a commit that referenced this pull request Jul 7, 2023
Signed-off-by: Ian Cardoso <osodracnai@gmail.com>
(cherry picked from commit 324f9ad)
osodracnai added a commit that referenced this pull request Jul 7, 2023
Signed-off-by: Ian Cardoso <osodracnai@gmail.com>
(cherry picked from commit 324f9ad)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants