Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return a proper ResponseDeleteRange on Delete calls #146

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Return a proper ResponseDeleteRange on Delete calls #146

merged 1 commit into from
Nov 18, 2022

Conversation

neoaggelos
Copy link
Contributor

Fixes #145

@neoaggelos
return ResponseDeleteRange responses on Delete
501f50e 
Signed-off-by: Angelos Kolaitis <neoaggelos@gmail.com>
brandond
brandond approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! This was likely just a case of copypasta that worked because nothing was actually checking the response.

@brandond brandond merged commit 20c4783 into k3s-io:master Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandond brandond brandond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

invalid DeleteRange response: "..." with 1.26.0-rc.0
2 participants
@neoaggelos @brandond