Update NATS to v2.9.18 #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Byron Ruth <byron@nats.io>
brandond
approved these changes
Jun 19, 2023
|
I see that CI has failed, is there anything interesting related to this change in the log? |
Signed-off-by: Byron Ruth <byron@nats.io>
|
I forgot to update the actual test script for external NATS, so just did that. I looked at the failure and tried to track down where/why it would occur, but impacts the older NATS server versions (2.7.x, and 2.8.x, no longer recommended to use). Is there a standard policy arounds backwards compat for kine drivers? That said personally I want to understand what changed in, where I suspect, the Go NATS library causing the older server versions to fail.. |
|
Got info on the bug reported here: nats-io/nats.go#1321 and fixed here: nats-io/nats.go#1325. Patch release coming this week, so we can wait to merge this until I bump the Go client with the fix. |
Signed-off-by: Byron Ruth <byron@nats.io>
Signed-off-by: Byron Ruth <byron@nats.io>
gshilei
pushed a commit
to gshilei/kine
that referenced
this pull request
Oct 31, 2023
* Update NATS to v2.9.18 * Update test-run-nats to 2.9.18 Signed-off-by: Byron Ruth <byron@nats.io> Signed-off-by: zhiyuan <guoshilei.gsl@antgroup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.