Fix SQLLog.compactor #209
Merged
Fix SQLLog.compactor #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because it will cause memory leak if we do not stop ticker when the function has completed. Signed-off-by: hang.jiang <hang.jiang@daocloud.io>
|
Sure, but this goroutine never exits unless the whole process is terminating. Have you run into any circumstances where this actual causes a leak of the timer? |
|
@brandond I think you are right, this pr just keeps code normal. |
brandond
approved these changes
Aug 25, 2023
brandond
added a commit
to johnatasr/k3s
that referenced
this pull request
Sep 15, 2023
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because it will cause memory leak if we do not stop ticker when the function has completed.