Bugfix? create pgql database if not exists #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase your changes? It appears that you are missing some changes to the tests and this is causing CI to fail. I suspect that this was broken by #179 - we should add or modify the tests so that they also exercise the database creation code. I believe they all currently use the default database. |
With the current master branch code (commit afb2121) I see the following error: root@vm2:/home/vagrant# kine --debug --endpoint postgres://postgres:postgresql@localhost:5432/foobster INFO[2023-11-03T20:07:09.379099258Z] metrics server is starting to listen at :8080 INFO[2023-11-03T20:07:09.379709686Z] starting metrics server path /metrics FATA[2023-11-03T20:07:09.40247106Z] building kine: failed to connect to `host=localhost user=postgres database=foobster`: server error (FATAL: database "foobster" does not exist (SQLSTATE 3D000)) This is fixed with the current commit. Signed-off-by: Oz Tiram <oz.tiram@gmail.com>
oz123
force-pushed
the
pg-fix-createDBIfNotExists
branch
from
7e02391
to
b3e6e04
Compare
|
@brandond thanks for reviewing my PR so quickly. I rebased the patch against the current master. 🤞 that the tests work now. |
brandond
approved these changes
Nov 7, 2023
dereknola
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current master branch code
(commit afb2121)
I see the following error:
root@vm2:/home/vagrant# kine --debug --endpoint postgres://postgres:postgresql@localhost:5432/foobster INFO[2023-11-03T20:07:09.379099258Z] metrics server is starting to listen at :8080 INFO[2023-11-03T20:07:09.379709686Z] starting metrics server path /metrics FATA[2023-11-03T20:07:09.40247106Z] building kine: failed to connect to
host=localhost user=postgres database=foobster: server error (FATAL: database "foobster" does not exist (SQLSTATE 3D000))This is fixed with the current commit.