Update DNSEndpoint CRD #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k0da
requested review from
donovanmuller,
kuritka,
somaritane and
ytsarev
as code owners
ytsarev
requested changes
Mar 10, 2021
somaritane
suggested changes
Mar 10, 2021
|
@ytsarev this is unrelated to external-dns version. There are no changes to the object itself, what changed is a representation of an object to kubernetes API |
ytsarev
requested changes
Mar 10, 2021
There was a problem hiding this comment.
see terratest
Error: CustomResourceDefinition.apiextensions.k8s.io "dnsendpoints.externaldns.k8s.io" is invalid: metadata.annotations[api-approved.kubernetes.io]: Required value: protected groups must have approval annotation "api-approved.kubernetes.io", see https://github.com/kubernetes/enhancements/pull/1111
|
Just a question: all fields in CRD are optional. Is it ok ? |
|
Sent upstream for approval kubernetes-sigs/external-dns#2007 |
Sync DNSEndpoint CRD from upstream where it was updated to apiextentions.k8s.io/v1 kubernetes-sigs/external-dns#2001 Signed-off-by: Dinar Valeev <dinar.valeev@absa.africa>
|
Upstream finally got merged, updated PR with new annotated CRD |
kuritka
reviewed
Mar 16, 2021
kuritka
approved these changes
Mar 16, 2021
ytsarev
approved these changes
Mar 16, 2021
somaritane
approved these changes
Mar 16, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync DNSEndpoint CRD from upstream where it was updated to
apiextentions.k8s.io/v1
kubernetes-sigs/external-dns#2001
Signed-off-by: Dinar Valeev dinar.valeev@absa.africa