Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed kernel transfer function #98

Conversation

David-Morales-Norato
Copy link
Contributor

This pull request addresses the error reported in Issue #97 concerning the incorrect kernel equation in the odak.learn.wave.classical.get_transfer_function_fresnel_kernel function.

@kaanaksit kaanaksit merged commit bf00fda into kaanaksit:master Jun 9, 2024
@kaanaksit
Copy link
Owner

Hi David,

Thank you for bringing this issue to my attention and showing interest in my work.

Both equations are in fact providing a similar response in the Fresnel region, and they are practically both correct. We use these kernels mostly in the Fresnel region. I am happy to merge your request. But in case you decide to contribute this project, a style related thing that I would encourage you to follow:

Please add space between mathematical operations. For instance, from your code:

H = torch.exp(1j*distance* (k- torch.pi *wavelength*(FX**2 + FY**2)))

Should be:

H = torch.exp(1j * distance * (k - torch.pi * wavelength * (FX ** 2 + FY ** 2)))

I have also included your name to THANKS.txt. I appreciate it if you could have a separate pull request for updating CITATION.cff in the root directory. Please make sure to add your orcid ID. Btw, you can always approach me for scientificc collaborations related to holography. My email is kaanaksit@kaanaksit.com.

Thanks,

Best regards,
Kaan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants