Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BE: FE: Topics: Allow custom topic params upon creation #271

Merged
merged 14 commits into from
Apr 26, 2024

Conversation

Nilumilak
Copy link
Member

@Nilumilak Nilumilak commented Apr 6, 2024

Resolve #84

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Nilumilak Nilumilak requested a review from a team as a code owner April 6, 2024 11:50
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Apr 6, 2024
@Nilumilak Nilumilak self-assigned this Apr 6, 2024
@Nilumilak Nilumilak added scope/frontend Related to frontend changes type/enhancement En enhancement/improvement to an already existing feature labels Apr 6, 2024
@Nilumilak Nilumilak requested a review from Mgrdich April 19, 2024 08:56
Copy link

sonarcloud bot commented Apr 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Nilumilak Nilumilak requested a review from a team as a code owner April 23, 2024 16:29
@VladSenyuta
Copy link
Contributor

@Haarolean hey, I've faced failed brokersConfigEditCheck at this PR
and while investigation really reproduced it locally. it's not because of test :)

Brokers -> open one -> Configs tab -> search for 'log.cleaner.min.compaction.lag.ms'
Edit-> set new value -> Save -> Confirm

I really saw twice when after setting new value there's displayed old one

@Haarolean Haarolean changed the title Feature/custom params BE: FE: Topics: Allow custom topic params upon creation Apr 26, 2024
@Haarolean Haarolean merged commit c402f36 into main Apr 26, 2024
14 checks passed
@Haarolean Haarolean deleted the feature/custom_params branch April 26, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/frontend Related to frontend changes status/triage/completed Automatic triage completed status/triage/manual Manual triage in progress type/enhancement En enhancement/improvement to an already existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BE: FE: Topics: Allow custom topic params upon creation
4 participants