Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infra: Ensure image arch automatic inference #378

Merged
merged 1 commit into from
May 11, 2024

Conversation

hugomiguelabreu
Copy link
Contributor

@hugomiguelabreu hugomiguelabreu commented May 10, 2024

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Changes the base image used to ensure automatic inference, guaranteeing a correct base image for the built kafka-ui one.
Building the image with the updated base one the container boots successfully.

image

Closes: #376

Is there anything you'd like reviewers to focus on?

  • Build and Run locally.

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

@hugomiguelabreu hugomiguelabreu requested review from a team as code owners May 10, 2024 07:25
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels May 10, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi hugomiguelabreu! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

@hugomiguelabreu
Copy link
Contributor Author

I am not sure about the image used as I wasn't able to infer the actual version from the hash. I based off the latest one, locking the hotfix.

Let me know if we need some other particular version to be compliant with any active CVE

@hugomiguelabreu hugomiguelabreu mentioned this pull request May 10, 2024
4 tasks
Copy link

@paxadax paxadax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you , this will be really helpful

@Haarolean Haarolean changed the title fix(Dockerfile): ensure arm / amd automatic inference Infra: ensure arm / amd automatic inference May 10, 2024
@Haarolean
Copy link
Member

I am not sure about the image used as I wasn't able to infer the actual version from the hash. I based off the latest one, locking the hotfix.

Let me know if we need some other particular version to be compliant with any active CVE

the point was pinning the version, but your solution is better, I guess, since the minor version won't get updated either :) This should work generally, unless we have to bump the version before a minor is released to circumvent any CVEs in alpine. Thanks!

@Haarolean Haarolean added type/enhancement En enhancement/improvement to an already existing feature scope/infra CI, CD, dev. env, etc. and removed status/triage/manual Manual triage in progress labels May 10, 2024
@Haarolean Haarolean self-assigned this May 10, 2024
@Haarolean Haarolean changed the title Infra: ensure arm / amd automatic inference Infra: Ensure image arch automatic inference May 10, 2024
@Haarolean Haarolean merged commit 42c236d into kafbat:main May 11, 2024
46 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/infra CI, CD, dev. env, etc. status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infra: Ship ARM images
3 participants