Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BE: Auth: Support LDAP nested groups #391

Merged
merged 1 commit into from
May 19, 2024
Merged

Conversation

RomainDubois
Copy link
Contributor

@RomainDubois RomainDubois commented May 15, 2024

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Closes #390
I changed the way the LDAP groups of the user are collected. Instead of direct request to LDAP, I rely on the Spring LDAP class which has been designed to handle nested groups.

Is there anything you'd like reviewers to focus on?
No

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@RomainDubois RomainDubois requested a review from a team as a code owner May 15, 2024 14:51
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels May 15, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi RomainDubois! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

@Haarolean Haarolean changed the title Handle LDAP nested groups (#390) BE: Auth: Support LDAP nested groups May 16, 2024
@Haarolean Haarolean added type/enhancement En enhancement/improvement to an already existing feature scope/backend Related to backend changes area/auth App authentication related issues and removed status/triage/manual Manual triage in progress labels May 16, 2024
@Haarolean
Copy link
Member

@RomainDubois does replacing the super class impact the existing setups in any way?

@RomainDubois
Copy link
Contributor Author

@RomainDubois does replacing the super class impact the existing setups in any way?

No, it inherits from the previous parent class and only overrides the method to fetch groups.
Source here : https://github.com/spring-projects/spring-security/blob/main/ldap/src/main/java/org/springframework/security/ldap/userdetails/NestedLdapAuthoritiesPopulator.java

@Haarolean Haarolean merged commit a4d678e into kafbat:main May 19, 2024
44 of 46 checks passed
@Haarolean
Copy link
Member

@RomainDubois thanks for your first contribution to kafbat ui!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/auth App authentication related issues scope/backend Related to backend changes status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auth: Support LDAP nested groups
2 participants