Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE: Messages: Fix refresh does pagination instead #417

Merged
merged 5 commits into from
May 26, 2024
Merged

FE: Messages: Fix refresh does pagination instead #417

merged 5 commits into from
May 26, 2024

Conversation

Mgrdich
Copy link
Contributor

@Mgrdich Mgrdich commented May 25, 2024

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Mgrdich Mgrdich requested a review from a team as a code owner May 25, 2024 17:35
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress labels May 25, 2024
@Mgrdich Mgrdich self-assigned this May 25, 2024
@kapybro kapybro bot added area/messages status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels May 25, 2024
@Mgrdich Mgrdich linked an issue May 25, 2024 that may be closed by this pull request
4 tasks
@Haarolean Haarolean marked this pull request as draft May 25, 2024 17:56
@Mgrdich Mgrdich marked this pull request as ready for review May 25, 2024 18:29
@Haarolean Haarolean changed the title Fix the refresh pagination issue on topic messages FE: Fix refresh does pagination instead May 26, 2024
@Haarolean Haarolean added scope/frontend Related to frontend changes type/bug Something isn't working and removed status/triage/manual Manual triage in progress labels May 26, 2024
@Haarolean Haarolean changed the title FE: Fix refresh does pagination instead FE: Messages: Fix refresh does pagination instead May 26, 2024
@Haarolean Haarolean merged commit d8fd5c3 into main May 26, 2024
26 checks passed
@Haarolean Haarolean deleted the issue416 branch May 26, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/messages scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FE: Messages: Refresh doesn't refresh, it moves the offsets as if pagination
2 participants