Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Remove missing compose links #487

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

kis87988
Copy link
Contributor

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
documentation

Is there anything you'd like reviewers to focus on?
documentation

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@kis87988 kis87988 requested a review from a team as a code owner July 20, 2024 19:44
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Jul 20, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi kis87988! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

Copy link
Member

@Haarolean Haarolean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate on the changes you've made?

@kis87988 kis87988 force-pushed the fix_docker_compose_docs_missing branch from ca2972d to 8825b31 Compare July 21, 2024 03:13
@kis87988
Copy link
Contributor Author

Can you elaborate on the changes you've made?

Sorry, I copied the update from another repo. This update is removing not exist compose in the md file.

@Haarolean Haarolean self-requested a review July 21, 2024 21:14
@Haarolean Haarolean changed the title Update DOCKER_COMPOSE.md Docs: Remove missing compose links Jul 21, 2024
@Haarolean Haarolean added type/refactor Refactoring task impact/documentation A PR with changes which should be addressed in the documentation and removed status/triage/manual Manual triage in progress labels Jul 21, 2024
@Haarolean Haarolean merged commit 8c70126 into kafbat:main Jul 21, 2024
7 checks passed
@Haarolean
Copy link
Member

@kis87988 thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/documentation A PR with changes which should be addressed in the documentation status/triage/completed Automatic triage completed type/refactor Refactoring task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants