Support TXT, SRV and PTR records #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GreyCat
reviewed
May 27, 2020
network/dns_packet.ksy
Outdated
| - id: text | ||
| type: str | ||
| size: length | ||
| encoding: UTF-8 |
There was a problem hiding this comment.
Are we sure that this comes in UTF-8? My guess would be that DNS protocol longs before predates Unicode, so likely it's treated as raw byte array?
There was a problem hiding this comment.
Good point.
Let me double check.
There was a problem hiding this comment.
https://tools.ietf.org/html/rfc1464
RFC says ASCII.
I’ll check whether there is a update to this RFC.
There was a problem hiding this comment.
ASCII is subset of UTF-8.
There was a problem hiding this comment.
Let's stick with UTF-8 for now then, and we can always make it more strict or more relaxed later.
|
Merging this, thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.