Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename clippy feature #137

Merged
merged 6 commits into from
Jun 1, 2024
Merged

Rename clippy feature #137

merged 6 commits into from
Jun 1, 2024

Conversation

vbrandl
Copy link
Contributor

@vbrandl vbrandl commented May 8, 2024

Currently clippy fails with

`feature = "cargo-clippy"` was replaced by `clippy`

This PR renames all instances of feature = "cargo-clippy" in templates with feature = "clippy"

Valentin Brandl and others added 6 commits May 8, 2024 14:55
Currently clippy fails with feature = "cargo-clippy"` was replaced by `clippy`
Allow clippy::useless_attribute directly.
Allow clippy::useless_attribute directly.
Copy link
Owner

@kaj kaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This was long overdue. I took the liberty of cleaning things up one step further.

@kaj kaj merged commit eb29b3a into kaj:master Jun 1, 2024
27 checks passed
@vbrandl vbrandl deleted the fix/clippy-feature-rename branch June 2, 2024 00:49
@vbrandl
Copy link
Contributor Author

vbrandl commented Jun 22, 2024

Do you plan to publish a release containing this and the other changes you made in the last few days?
This would make my CI pipelines pass again :)

@kaj
Copy link
Owner

kaj commented Jun 25, 2024

Yes, I'm hoping for a release "soonish". I hope to do something about #134 first, but I may have to give up on that.

kaj added a commit that referenced this pull request Jun 30, 2024
* The main branch in git is now `main` rather than `master`.
* Update clippy lint usage to get rid of warnings in all code using
  ructe (PR #137).  Thanks @vbradl!
* Identified a problem with `Content` parameters sent through
  intermediate templates, and documented a workaround for it (Issue
  #134, PR #141).  Thanks @drehren and @kornelski.
* The `axum` test is mentioned in [`README.md`] (PR #138).
  Thanks @abd0-omar!
* Update `base64` to 0.22.1 and `itertools` dependency to 0.13.0.
* MSRV is now 1.61.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants