Skip to content

Commit

Permalink
remove the --feat-type options in steps/libs/
Browse files Browse the repository at this point in the history
  • Loading branch information
Hang Lyu committed Jun 25, 2017
1 parent a341118 commit 02eaa44
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 9 deletions.
4 changes: 1 addition & 3 deletions egs/wsj/s5/steps/libs/nnet3/train/chain_objf/acoustic_model.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def generate_chain_egs(dir, data, lat_dir, egs_dir,
left_context_initial=-1, right_context_final=-1,
frame_subsampling_factor=3,
alignment_subsampling_factor=3,
feat_type='raw', online_ivector_dir=None,
online_ivector_dir=None,
frames_per_iter=20000, frames_per_eg_str="20", srand=0,
egs_opts=None, cmvn_opts=None, transform_dir=None):
"""Wrapper for steps/nnet3/chain/get_egs.sh
Expand All @@ -79,7 +79,6 @@ def generate_chain_egs(dir, data, lat_dir, egs_dir,
"""steps/nnet3/chain/get_egs.sh {egs_opts} \
--cmd "{command}" \
--cmvn-opts "{cmvn_opts}" \
--feat-type {feat_type} \
--transform-dir "{transform_dir}" \
--online-ivector-dir "{ivector_dir}" \
--left-context {left_context} \
Expand All @@ -97,7 +96,6 @@ def generate_chain_egs(dir, data, lat_dir, egs_dir,
{data} {dir} {lat_dir} {egs_dir}""".format(
command=run_opts.command,
cmvn_opts=cmvn_opts if cmvn_opts is not None else '',
feat_type=feat_type,
transform_dir=(transform_dir
if transform_dir is not None
else ''),
Expand Down
4 changes: 1 addition & 3 deletions egs/wsj/s5/steps/libs/nnet3/train/frame_level_objf/acoustic_model.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ def generate_egs(data, alidir, egs_dir,
left_context, right_context,
run_opts, stage=0,
left_context_initial=-1, right_context_final=-1,
feat_type='raw', online_ivector_dir=None,
online_ivector_dir=None,
samples_per_iter=20000, frames_per_eg_str="20", srand=0,
egs_opts=None, cmvn_opts=None, transform_dir=None):

Expand All @@ -36,7 +36,6 @@ def generate_egs(data, alidir, egs_dir,
"""steps/nnet3/get_egs.sh {egs_opts} \
--cmd "{command}" \
--cmvn-opts "{cmvn_opts}" \
--feat-type {feat_type} \
--transform-dir "{transform_dir}" \
--online-ivector-dir "{ivector_dir}" \
--left-context {left_context} \
Expand All @@ -50,7 +49,6 @@ def generate_egs(data, alidir, egs_dir,
{data} {alidir} {egs_dir}
""".format(command=run_opts.command,
cmvn_opts=cmvn_opts if cmvn_opts is not None else '',
feat_type=feat_type,
transform_dir=(transform_dir
if transform_dir is not None else
''),
Expand Down
4 changes: 1 addition & 3 deletions egs/wsj/s5/steps/libs/nnet3/train/frame_level_objf/raw_model.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ def generate_egs_using_targets(data, targets_scp, egs_dir,
left_context, right_context,
run_opts, stage=0,
left_context_initial=-1, right_context_final=-1,
feat_type='raw', online_ivector_dir=None,
online_ivector_dir=None,
target_type='dense', num_targets=-1,
samples_per_iter=20000, frames_per_eg_str="20",
srand=0, egs_opts=None, cmvn_opts=None,
Expand Down Expand Up @@ -52,7 +52,6 @@ def generate_egs_using_targets(data, targets_scp, egs_dir,
"""steps/nnet3/get_egs_targets.sh {egs_opts} \
--cmd "{command}" \
--cmvn-opts "{cmvn_opts}" \
--feat-type {feat_type} \
--transform-dir "{transform_dir}" \
--online-ivector-dir "{ivector_dir}" \
--left-context {left_context} \
Expand All @@ -68,7 +67,6 @@ def generate_egs_using_targets(data, targets_scp, egs_dir,
{data} {targets_scp} {egs_dir}
""".format(command=run_opts.egs_command,
cmvn_opts=cmvn_opts if cmvn_opts is not None else '',
feat_type=feat_type,
transform_dir=(transform_dir
if transform_dir is not None
else ''),
Expand Down

2 comments on commit 02eaa44

@danpovey
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vimalmanohar, are there any places where we are still using this feat-type option?

@vimalmanohar
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the feat_type is set to lda in any recipes.

Please sign in to comment.