-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the gawk-specific feature problems in prepare dict scripts. #1147
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some lower/upper-case disagreements
@@ -117,10 +117,7 @@ patch <local/dict.patch $dir/lexicon0.txt || exit 1; | |||
|
|||
#(2a) Dictionary preparation: | |||
# Pre-processing (Upper-case, remove comments) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plese remove the 'Upper-case' comment here since it's not being done.
$srcdict | sort | awk '($0 !~ /^[:space:]*$/) {print}' \ | ||
> $dir/lexicon1.txt || exit 1; | ||
|
||
grep -v '^#' $srcdict | tr '[a-z]' '[A-Z]' | awk 'NF>0' | sort > $dir/lexicon1.txt || exit 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment said 'Upper-case' but the code was actually lower-casing. So please lower-case instead, and change the comment. See if there are similar issues elsewhere.
OK, but please change the comments so that they correspond to what is actually being done w.r.t. casing. All comments say 'upper-case', but some do lower, some do nothing. |
Done! |
Thanks! Merging. |
Fix the gawk-specific feature problems in prepare dict scripts.
Described here: #1143