Use a regular expression to tokenize lexicon.txt #2676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some UTF-8 characters (for example Š) are interpreted in latin-1 as containing whitespace. For example, Š consists of bytes c5 and a0 in UTF-8, but a0 corresponds to non-breaking space in latin-1. This means that words containing Š are not tokenized correctly when reading lexicon.txt. This change ensures that lexicon.txt is tokenized using only space or tab characters.
|
Thanks. @xiaohui-zhang could you please make a PR for the silprob version of that script? I'm concerned @alumae may not be online. |
danpovey
added a commit
to danpovey/kaldi
that referenced
this pull request
Sep 4, 2018
danpovey
added a commit
that referenced
this pull request
Sep 4, 2018
|
Sure Dan.
…On Tue, Sep 4, 2018 at 5:24 AM Daniel Povey ***@***.***> wrote:
Merged #2676 <#2676> into master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2676 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ANiEETo2pNokJJl1AOt2E5XVlExkpJ6Vks5uXps8gaJpZM4WYpFq>
.
--
Xiaohui
|
|
@xiaohui-zhang it's OK now, I did it... |
|
sorry about that XD
…On Thu, Sep 6, 2018 at 10:48 AM Daniel Povey ***@***.***> wrote:
@xiaohui-zhang <https://github.com/xiaohui-zhang> it's OK now, I did it...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2676 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ANiEEUOoy3j9gogJ2rDeflMxJoSdt-zMks5uYYo7gaJpZM4WYpFq>
.
--
Xiaohui
|
Skaiste
pushed a commit
to Skaiste/idlak
that referenced
this pull request
Sep 26, 2018
… tokenizing lexicon (kaldi-asr#2676) Some UTF-8 characters (for example Š) are interpreted in latin-1 as containing whitespace. For example, Š consists of bytes c5 and a0 in UTF-8, but a0 corresponds to non-breaking space in latin-1. This means that words containing Š are not tokenized correctly when reading lexicon.txt. This change ensures that lexicon.txt is tokenized using only space or tab characters.
Skaiste
pushed a commit
to Skaiste/idlak
that referenced
this pull request
Sep 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some UTF-8 characters (for example Š) are interpreted in latin-1 as containing whitespace. For example, Š consists of bytes c5 and a0 in UTF-8, but a0 corresponds to non-breaking space in latin-1. This means that words containing Š are not tokenized correctly when reading lexicon.txt.
This change ensures that lexicon.txt is tokenized using only space or tab characters.