[fix:cudadecoder]application hangs if numFrames == 0 #4198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spike-liu
changed the title
spike-liu
changed the title
|
Makes sense. Thanks for your help! |
|
You are welcome, @hugovbraun. |
|
This issue has been automatically marked as stale by a bot solely because it has not had recent activity. Please add any comment (simply 'ping' is enough) to prevent the issue from being closed for 60 more days if you believe it should be kept open. |
|
@hugovbraun, my understanding is that this code is being/has been deprecated in favor of batched-...-pipeline2.cc? Is this moot now? Is it supported on Jetson only, or not at all? |
|
We've deprecated batched-threaded-nnet3-cuda-pipeline.cc, but have not removed it yet. So I'm merging this fix. The CI failure is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cuda_pipeline->WaitForGroup() will never return if numFrames == 0, so maintain all_group_tasks_not_done variable and notify_all if nothing is left in the group.