Prevent dangling symlink creation #4644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anna-kartynnik
referenced
this pull request
Oct 7, 2021
There are presumably places other than utils/subset_data_dir.sh that can use this. utt2num_frames can be produced by passing --write_utt2num_frames=true to steps/make_mfcc.sh. This is much faster than running feat-to-len after the fact.
danpovey
reviewed
Oct 7, 2021
egs/wsj/s5/utils/subset_data_dir.sh
Outdated
| @@ -116,7 +116,7 @@ else | |||
| # Select $numutt shortest utterances. | |||
| . ./path.sh | |||
| if [ -f $srcdir/utt2num_frames ]; then | |||
| ln -sf $srcdir/utt2num_frames $destdir/tmp.len | |||
| ln -sf $(readlink -f $srcdir)/utt2num_frames $destdir/tmp.len | |||
There was a problem hiding this comment.
The -f option to readlink does not work on a mac. I think it would be better to use utils/make_absolute.sh instead of readlink -f.
There was a problem hiding this comment.
Thanks! I didn't know support for BSD-like systems is intended, because searching for readlink -f had quite a few hits. Will use make_absolute.sh.
There was a problem hiding this comment.
yeah, some dataset-specific scripts still have that, but it's discouraged. thanks!
anna-kartynnik
force-pushed
the
fix-dangling-symlink
branch
from
78adc6e
to
f4fcced
Compare
When `$srcdir` is a relative path, the path written by `ln` is invalid w.r.t. the symlink directory. Use an absolute path instead.
anna-kartynnik
force-pushed
the
fix-dangling-symlink
branch
from
f4fcced
to
d528460
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
$srcdiris a relative path, the path written bylnis invalid w.r.t. the symlink directory. Use an absolute path instead.