Copy utt2lang when using utils/copy_data_dir.sh #4789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Nice catch, thank you! |
rkjaran
added a commit
to tiro-is/kaldi
that referenced
this pull request
Nov 18, 2022
* 'master' of github.com:kaldi-asr/kaldi: Update run_blstm.sh (kaldi-asr#4790) Provide provision to pass subword separator as argument to make_position_dependent_subword_lexicon.py (kaldi-asr#4794) change [utter] to [utterance.] in data_prep.dox (kaldi-asr#4795) [egs] Kill feral dupes of --num-threads in few local eg scripts (kaldi-asr#4792) [scripts] Move otherwise misleading comment in mkgraph.sh (kaldi-asr#4787) [scripts] Copy utt2lang in copy_data_dir.sh (kaldi-asr#4789) Fix: ali-to-post piping in post-to-tacc example (kaldi-asr#4788) [infra] add cpu-only docker build (kaldi-asr#4783) [infra] docker images automatically using gh (kaldi-asr#4782) remove the c++17 removed function random_shuffle remove obsoleted and C++17 incompatible unary_function<>, resolves kaldi-asr#4732 [egs] Set PYTHONUNBUFFERED=1 in all recipes (kaldi-asr#4770) Fix typo in gen_cmake_skeleton (kaldi-asr#4779) use last segment of the CXX as the ccbin compiler for cuda (kaldi-asr#4778) Windows conda fixes (kaldi-asr#4777) Replace TravisCI with github actions (kaldi-asr#4776) Kaldi recipe for SPGISpeech (kaldi-asr#4772) fix portaudio install script, closes kaldi-asr#4755 (kaldi-asr#4773)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
utils/copy_data_dir.shdoes not copyutt2langto destination directory. However,utils/subset_data_dir.shdoes as follows:kaldi/egs/wsj/s5/utils/subset_data_dir.sh
Lines 141 to 142 in 0fb502d
Because I encountered this issue when making multi-language and multi-speaker TTS model, I wrote this PR.