fix(SUP-41001): Download button not available #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tzipi-kaltura
requested review from
JonathanTGold,
semarche-kaltura,
lianbenjamin and
SivanA-Kaltura
5 tasks
semarche-kaltura
approved these changes
Apr 8, 2024
Tzipi-kaltura
added a commit
to kaltura/playkit-js-downloads
that referenced
this pull request
Apr 8, 2024
Issue: When there is one caption on status "processing" the download button is not displayed on the player even if we have additional captions on the entry Root cause: There is request for BE to get all the urls for the captions, the request for the caption with status "processing" return kalturaApiException so all the request returns as error as a result the download plugin is not displayed. Solution: Send "false" in the doRequest as "requestsMustSucceed" so even if one of the caption is not ready the response returns with the other urls. Since the exception result is removed from the response, the response and the request arrays is not necessarily arranged in the same indexes so set the urls according to the captionAssetId from the url. part of the fix here - kaltura/playkit-js-providers#237 Solves SUP-41001
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
part of - kaltura/playkit-js-downloads#46
Resolves SUP-41001