This repository has been archived by the owner on Mar 31, 2020. It is now read-only.
Replace default argument value with a no-args constructor #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading reporters from the configuration file uses Java reflection to instatiate the reporter with its no-args constructor. No such constructor was generated for `InfluxDBReporter` (the default argument value doesn’t generate one).
|
@rb3ckers thanks a lot for this PR! It totally went off my radar, same as your other PR. Will release both changes asap! |
|
Thanks. No problem though. We were already running with the forked version. Though it is nice to be able to drop the fork again. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading reporters from the configuration file uses Java reflection to instatiate the reporter with its no-args constructor. No such constructor was generated for
InfluxDBReporter(the default argument value doesn’t generate one).With version 1.0.2 of the InfluxDBReporter I get this exception when enabling it via the configuration:
java.lang.NoSuchMethodException: kamon.influxdb.InfluxDBReporter.<init>().