Skip to content

Commit

Permalink
Use recreate strategy temporarily
Browse files Browse the repository at this point in the history
  • Loading branch information
sergiimk committed Sep 11, 2024
1 parent f119ffa commit 4e2c418
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
2 changes: 1 addition & 1 deletion charts/kamu-api-server/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: kamu-api-server
description: API server component of the Kamu Compute Node
type: application
version: 0.36.0
version: 0.36.1
appVersion: "0.36.0"
home: https://kamu.dev
icon: https://www.kamu.dev/images/kamu_logo_icon_bg_square.png
Expand Down
8 changes: 8 additions & 0 deletions charts/kamu-api-server/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,14 @@ spec:
{{- if not .Values.autoscaling.enabled }}
replicas: {{ .Values.replicaCount }}
{{- end }}
# TODO: This is an unfortunate temporary measure to prevent race conditions between
# the old process that is executing flows/tasks and processing domain events
# and a new replacement process that will try to pick up unprocessed work upon startup.
# Soon this will be replaced by proper DB locking / leader election, but meanwhile `Recreate`
# strategy ensures that the old pod is killed before deploying a new one. This significantly
# increases the chance of causing downtime if a replacement pod fails to start correctly.
strategy:
type: Recreate
selector:
matchLabels:
{{- include "kamu-api-server.selectorLabels" . | nindent 6 }}
Expand Down

0 comments on commit 4e2c418

Please sign in to comment.