Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Admin users #414

Merged
merged 12 commits into from
Jan 10, 2024
Merged

Introduce Admin users #414

merged 12 commits into from
Jan 10, 2024

Conversation

s373r
Copy link
Member

@s373r s373r commented Jan 3, 2024 •
edited
Loading

Related issue: #276

@s373r s373r changed the title Sign test Introduce Admin users Jan 3, 2024
@s373r s373r self-assigned this Jan 4, 2024
@s373r s373r force-pushed the feature/introduce-admin-users branch 2 times, most recently from da7c769 to 1f10c31 Compare January 8, 2024 14:04
@s373r s373r marked this pull request as ready for review January 8, 2024 14:35
@s373r s373r marked this pull request as draft January 8, 2024 16:55
@s373r s373r force-pushed the feature/introduce-admin-users branch from debd596 to 9a28eb5 Compare January 8, 2024 17:10
@s373r s373r requested a review from sergiimk January 8, 2024 17:11
@s373r s373r marked this pull request as ready for review January 8, 2024 17:11
@s373r s373r force-pushed the feature/introduce-admin-users branch from 9a28eb5 to b7ad22d Compare January 8, 2024 17:31
zaychenko-sergei
zaychenko-sergei requested changes Jan 8, 2024
View reviewed changes
src/adapter/graphql/src/queries/admin/admin.rs Show resolved Hide resolved
src/app/cli/src/services/accounts/models.rs Outdated Show resolved Hide resolved
src/app/cli/src/services/accounts/models.rs Outdated Show resolved Hide resolved
@zaychenko-sergei
Copy link
Contributor

The tests are failing, because regenerated GraphQL schema does not match what is committed.

@s373r s373r force-pushed the feature/introduce-admin-users branch 2 times, most recently from 7dbe2b9 to 0d51687 Compare January 9, 2024 10:13
@s373r s373r force-pushed the feature/introduce-admin-users branch from 0d51687 to ef80fae Compare January 10, 2024 15:09
zaychenko-sergei
zaychenko-sergei approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@zaychenko-sergei zaychenko-sergei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGELOG change added to already released version, start a new one

@s373r s373r force-pushed the feature/introduce-admin-users branch from ef80fae to 46ffb50 Compare January 10, 2024 15:27
@s373r s373r force-pushed the feature/introduce-admin-users branch from 46ffb50 to 00d5740 Compare January 10, 2024 15:34
@s373r s373r merged commit 52d2ef1 into master Jan 10, 2024
5 checks passed
@s373r s373r deleted the feature/introduce-admin-users branch January 10, 2024 15:47
@s373r s373r linked an issue Jan 10, 2024 that may be closed by this pull request
Introduce Admin users #276
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaychenko-sergei zaychenko-sergei zaychenko-sergei approved these changes

@rmn-boiko rmn-boiko Awaiting requested review from rmn-boiko

@sergiimk sergiimk Awaiting requested review from sergiimk

Assignees

@s373r s373r

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce Admin users
3 participants
@s373r @zaychenko-sergei @sergiimk