Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ElementIdConverter does not accept the nullable property. #2052

Merged
merged 2 commits into from
Jul 4, 2023
Merged

Fix ElementIdConverter does not accept the nullable property. #2052

merged 2 commits into from
Jul 4, 2023

Conversation

andy840119
Copy link
Member

Fix issue #2051.
Not very sure why fixed but still OK to give it a pass now.

@andy840119 andy840119 added the encoder/decoder About beatmap format decode/encoder label Jul 4, 2023
@andy840119 andy840119 added this to the 2023.0707 milestone Jul 4, 2023
@andy840119 andy840119 merged commit c39402d into karaoke-dev:master Jul 4, 2023
1 check passed
@andy840119 andy840119 deleted the able-to-support-the-null-case branch July 4, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
encoder/decoder About beatmap format decode/encoder size/M
Projects
None yet
Milestone
2023.0707
Development

Successfully merging this pull request may close these issues.
1 participant
@andy840119