New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change lyric id format. #2055

Merged

andy840119 merged 11 commits into karaoke-dev:master from andy840119:change-lyric-id-format

Jul 5, 2023

Member

andy840119 commented Jul 4, 2023 •

edited

Loading

Implement part of #2040.
And issue #2048 is avoided in this PR.

andy840119 added 11 commits

July 4, 2023 23:43


          Change the id type in the lyric object.

8f6c301


          There's no need to assign the lyric id outside.

3d10bdb

Also, should add the json property attribute to make sure that lyric id will be saved/load by json serializer.


          There's no need to give it a id in the test case.

03450b5


          There's no need to test the id because id is not changeable.

a1f8f02


          There's no need to assign the id because testing skin does not save t…

…he mapping rule.


          Implement the extension for able to change the id inside the lyric.

637784d

And note that `LyricExtensions` and `SingerExtensions` will be combined into the `PrimaryKeyExtension`.


          Fix the test case helper.

9434f21


          Fix the test case broken by assign the lyric id.

c7120c6


          Fix the lyric convertor test case.

f3de3d2


          Fix the remaining test cases.

aaea2be


          Fix serializer/deserializer the note.

173b101

andy840119 added the encoder/decoder label

andy840119 added this to the 2023.0707 milestone

pull-request-size bot added the size/L label

Member Author

andy840119 commented Jul 4, 2023

Bug #2054 is noticed in this PR.
It's OK to give it a pass.
Will fix the remaining issue in the next PR (maybe tomorrow).

andy840119 merged commit 4481ce9 into karaoke-dev:master

1 check passed

andy840119 deleted the change-lyric-id-format branch

July 5, 2023 02:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

encoder/decoder size/L