Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove authentication for exercise metrics endpoints #28

Merged
merged 1 commit into from
Feb 10, 2024
Merged

refactor: remove authentication for exercise metrics endpoints #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions app/controllers/api/v1/exercise_metrics_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,9 @@
module Api
module V1
class ExerciseMetricsController < ApplicationController
before_action :authenticate_user!, only: %i[create update]
skip_before_action :authenticate_user!, only: %i[index create update]

def index
current_user = User.find(params[:user_id])
options = { is_collection: true }

render json: ExerciseMetricSerializer.new(current_user.exercise_metrics, options)
Expand All @@ -23,6 +22,8 @@ def create
end

def update
exercise_metric = current_user.exercise_metrics.find(params[:id])

if exercise_metric.update(exercise_metric_params)
render json: ExerciseMetricSerializer.new(exercise_metric)
else
Expand All @@ -36,8 +37,8 @@ def exercise_metric_params
params.require(:exercise_metric).permit(:name, :steps, :distance_in_m, :intensity)
end

def exercise_metric
@exercise_metric ||= current_user.exercise_metrics.find(params[:id])
def current_user
@current_user ||= User.find(params[:user_id])
end
end
end
Expand Down
192 changes: 73 additions & 119 deletions spec/requests/api/v1/exercise_metrics_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,162 +25,116 @@
end

describe "POST #create" do
# rubocop:disable RSpec/NestedGroups
context "when the user is authenticated" do
context "when attributes are valid" do
it "renders a created response" do
jwt_token = sign_in

attributes = {
name: "test walk", steps: 1000, distance_in_m: 1000, intensity: "high"
}

post api_v1_exercise_metrics_path, headers: { authorization: jwt_token },
params: { exercise_metric: attributes }, as: :json

expect(response).to have_http_status(:created)
end

it "creates a new exercise metric for user" do
user = create(:user)
jwt_token = sign_in(user)

attributes = {
name: "test walk", steps: 1000, distance_in_m: 1000, intensity: "high"
}

post api_v1_exercise_metrics_path, headers: { authorization: jwt_token },
params: { exercise_metric: attributes }, as: :json

expect(user.reload.exercise_metrics.last.attributes).to include(
"name" => "test walk",
"steps" => 1000,
"distance_in_m" => 1000,
"intensity" => "high"
)
end
end

context "when attributes are invalid" do
it "renders an unprocessable_entity response" do
jwt_token = sign_in

attributes = {
name: nil, steps: 1000, distance_in_m: 1000, intensity: nil
}

post api_v1_exercise_metrics_path, headers: { authorization: jwt_token },
params: { exercise_metric: attributes }, as: :json
context "when attributes are valid" do
it "renders a created response" do
user = create(:user)

expect(response).to have_http_status(:unprocessable_entity)
end

it "doesn't create a new exercise metric for user" do
user = create(:user)
jwt_token = sign_in(user)

attributes = {
name: nil, steps: 1000, distance_in_m: 1000, intensity: nil
}
attributes = {
name: "test walk", steps: 1000, distance_in_m: 1000, intensity: "high"
}

post api_v1_exercise_metrics_path, headers: { authorization: jwt_token },
params: { exercise_metric: attributes }, as: :json
post api_v1_exercise_metrics_path, params: { exercise_metric: attributes, user_id: user.id }, as: :json

expect(user.reload.exercise_metrics).to be_empty
end
expect(response).to have_http_status(:created)
end
end
# rubocop:enable RSpec/NestedGroups

context "when the user is not authenticated" do
it "renders an unauthorized response" do
it "creates a new exercise metric for user" do
user = create(:user)

attributes = {
name: "test walk", steps: 1000, distance_in_m: 1000, intensity: "high"
}

post api_v1_exercise_metrics_path, headers: { authorization: nil },
params: { exercise_metric: attributes }, as: :json
post api_v1_exercise_metrics_path, params: { exercise_metric: attributes, user_id: user.id }, as: :json

expect(response).to have_http_status(:unauthorized)
expect(user.reload.exercise_metrics.last.attributes).to include(
"name" => "test walk",
"steps" => 1000,
"distance_in_m" => 1000,
"intensity" => "high"
)
end
end
end

describe "PUT #update" do
# rubocop:disable RSpec/NestedGroups
context "when the user is authenticated" do
context "when attributes are valid" do
it "renders a successful response" do
user = create(:user)
jwt_token = sign_in(user)
exercise_metric = create(:exercise_metric, user: user)
context "when attributes are invalid" do
it "renders an unprocessable_entity response" do
user = create(:user)

attributes = { steps: 2000, distance_in_m: 2000 }
attributes = {
name: nil, steps: 1000, distance_in_m: 1000, intensity: nil
}

put api_v1_exercise_metric_path(exercise_metric), headers: { authorization: jwt_token },
params: { exercise_metric: attributes }, as: :json
post api_v1_exercise_metrics_path, params: { exercise_metric: attributes, user_id: user.id }, as: :json

expect(response).to be_successful
end
expect(response).to have_http_status(:unprocessable_entity)
end

it "updates user's exercise metric" do
user = create(:user)
jwt_token = sign_in(user)
exercise_metric = create(:exercise_metric, name: "old test walk", user: user)
it "doesn't create a new exercise metric for user" do
user = create(:user)

attributes = { name: "new test walk" }
attributes = {
name: nil, steps: 1000, distance_in_m: 1000, intensity: nil
}

put api_v1_exercise_metric_path(exercise_metric), headers: { authorization: jwt_token },
params: { exercise_metric: attributes }, as: :json
post api_v1_exercise_metrics_path, params: { exercise_metric: attributes, user_id: user.id }, as: :json

expect(user.reload.exercise_metrics.last.name).to eq("new test walk")
end
expect(user.reload.exercise_metrics).to be_empty
end
end
end

context "when attributes are invalid" do
it "renders an unprocessable_entity response" do
user = create(:user)
jwt_token = sign_in(user)
exercise_metric = create(:exercise_metric, user: user)
describe "PUT #update" do
context "when attributes are valid" do
it "renders a successful response" do
user = create(:user)
exercise_metric = create(:exercise_metric, user: user)

attributes = {
name: nil, steps: 1000, distance_in_m: 1000, intensity: nil
}
attributes = { steps: 2000, distance_in_m: 2000 }

put api_v1_exercise_metric_path(exercise_metric), headers: { authorization: jwt_token },
params: { exercise_metric: attributes }, as: :json
put api_v1_exercise_metric_path(exercise_metric),
params: { exercise_metric: attributes, user_id: user.id }, as: :json

expect(response).to have_http_status(:unprocessable_entity)
end
expect(response).to be_successful
end

it "doesn't update user's exercise metric" do
user = create(:user)
jwt_token = sign_in(user)
exercise_metric = create(:exercise_metric, name: "old test walk", user: user)
it "updates user's exercise metric" do
user = create(:user)
exercise_metric = create(:exercise_metric, name: "old test walk", user: user)

attributes = { name: "new test walk", intensity: nil }
attributes = { name: "new test walk" }

put api_v1_exercise_metric_path(exercise_metric), headers: { authorization: jwt_token },
params: { exercise_metric: attributes }, as: :json
put api_v1_exercise_metric_path(exercise_metric),
params: { exercise_metric: attributes, user_id: user.id }, as: :json

expect(user.reload.exercise_metrics.last.name).to eq("old test walk")
end
expect(user.reload.exercise_metrics.last.name).to eq("new test walk")
end
end
# rubocop:enable RSpec/NestedGroups

context "when the user is not authenticated" do
it "renders an unauthorized response" do
exercise_metric = create(:exercise_metric)
context "when attributes are invalid" do
it "renders an unprocessable_entity response" do
user = create(:user)
exercise_metric = create(:exercise_metric, user: user)

attributes = {
name: "test walk", steps: 1000, distance_in_m: 1000, intensity: "high"
name: nil, steps: 1000, distance_in_m: 1000, intensity: nil
}

put api_v1_exercise_metric_path(exercise_metric), headers: { authorization: nil },
params: { exercise_metric: attributes }, as: :json
put api_v1_exercise_metric_path(exercise_metric),
params: { exercise_metric: attributes, user_id: user.id }, as: :json

expect(response).to have_http_status(:unprocessable_entity)
end

it "doesn't update user's exercise metric" do
user = create(:user)
exercise_metric = create(:exercise_metric, name: "old test walk", user: user)

attributes = { name: "new test walk", intensity: nil }

put api_v1_exercise_metric_path(exercise_metric),
params: { exercise_metric: attributes, user_id: user.id }, as: :json

expect(response).to have_http_status(:unauthorized)
expect(user.reload.exercise_metrics.last.name).to eq("old test walk")
end
end
end
Expand Down
Loading