Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add duration_in_min field to exercise_metrics table #29

Merged
merged 1 commit into from
Feb 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/controllers/api/v1/exercise_metrics_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def update
private

def exercise_metric_params
params.require(:exercise_metric).permit(:name, :steps, :distance_in_m, :intensity)
params.require(:exercise_metric).permit(:name, :steps, :distance_in_m, :intensity, :duration_in_min)
end

def current_user
Expand Down
1 change: 1 addition & 0 deletions app/models/exercise_metric.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,5 @@ class ExerciseMetric < ApplicationRecord

validates :steps, numericality: { greater_than_or_equal_to: 0 }
validates :distance_in_m, numericality: { greater_than_or_equal_to: 0 }
validates :duration_in_min, numericality: { greater_than_or_equal_to: 0 }
end
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# frozen_string_literal: true

class AddDurationInMinToExerciseMetric < ActiveRecord::Migration[7.1]
def change
add_column :exercise_metrics, :duration_in_min, :integer
end
end
3 changes: 2 additions & 1 deletion db/schema.rb

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

23 changes: 15 additions & 8 deletions db/seeds/02_exercise_metrics.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true

Rails.logger.debug "\t Seeding crowdfunding projects data..."
Rails.logger.debug "\t Seeding exercise metrics data..."

user = User.find_by!(email: "isabella_galvao@limao.com.br")

Expand All @@ -10,49 +10,56 @@
name: "Caminhada",
steps: 2000,
distance_in_m: 1520,
intensity: "normal"
intensity: "normal",
duration_in_min: 60
},
{
user: user,
name: "Caminhada",
steps: 5000,
distance_in_m: 3810,
intensity: "high"
intensity: "high",
duration_in_min: 60
},
{
user: user,
name: "Corrida",
steps: 10_000,
distance_in_m: 7620,
intensity: "high"
intensity: "high",
duration_in_min: 60
},
{
user: user,
name: "Caminhada",
steps: 700,
distance_in_m: 530,
intensity: "low"
intensity: "low",
duration_in_min: 15
},
{
user: user,
name: "Caminhada",
steps: 6000,
distance_in_m: 4570,
intensity: "high"
intensity: "high",
duration_in_min: 60
},
{
user: user,
name: "Corrida",
steps: 12_000,
distance_in_m: 9140,
intensity: "high"
intensity: "high",
duration_in_min: 60
},
{
user: user,
name: "Caminhada",
steps: 500,
distance_in_m: 380,
intensity: "low"
intensity: "low",
duration_in_min: 15
}
].each do |data|
ExerciseMetric.create!(data)
Expand Down
1 change: 1 addition & 0 deletions spec/factories/exercise_metrics_factories.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@
steps { 1000 }
distance_in_m { 1000 }
intensity { "low" }
duration_in_min { 30 }
end
end
1 change: 1 addition & 0 deletions spec/models/exercise_metric_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,6 @@

it { is_expected.to validate_numericality_of(:steps).is_greater_than_or_equal_to(0) }
it { is_expected.to validate_numericality_of(:distance_in_m).is_greater_than_or_equal_to(0) }
it { is_expected.to validate_numericality_of(:duration_in_min).is_greater_than_or_equal_to(0) }
end
end
8 changes: 4 additions & 4 deletions spec/requests/api/v1/exercise_metrics_controller_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
user = create(:user)

attributes = {
name: "test walk", steps: 1000, distance_in_m: 1000, intensity: "high"
name: "test walk", steps: 1000, distance_in_m: 1000, intensity: "high", duration_in_min: 60
}

post api_v1_exercise_metrics_path, params: { exercise_metric: attributes, user_id: user.id }, as: :json
Expand All @@ -42,7 +42,7 @@
user = create(:user)

attributes = {
name: "test walk", steps: 1000, distance_in_m: 1000, intensity: "high"
name: "test walk", steps: 1000, distance_in_m: 1000, intensity: "high", duration_in_min: 60
}

post api_v1_exercise_metrics_path, params: { exercise_metric: attributes, user_id: user.id }, as: :json
Expand All @@ -61,7 +61,7 @@
user = create(:user)

attributes = {
name: nil, steps: 1000, distance_in_m: 1000, intensity: nil
name: nil, steps: 1000, distance_in_m: 1000, intensity: nil, duration_in_min: nil
}

post api_v1_exercise_metrics_path, params: { exercise_metric: attributes, user_id: user.id }, as: :json
Expand All @@ -73,7 +73,7 @@
user = create(:user)

attributes = {
name: nil, steps: 1000, distance_in_m: 1000, intensity: nil
name: nil, steps: 1000, distance_in_m: 1000, intensity: nil, duration_in_min: nil
}

post api_v1_exercise_metrics_path, params: { exercise_metric: attributes, user_id: user.id }, as: :json
Expand Down
Loading