Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client config in karma.conf.js is overwritten #79

Closed
buchanae opened this issue Dec 15, 2013 · 4 comments
Closed

client config in karma.conf.js is overwritten #79

buchanae opened this issue Dec 15, 2013 · 4 comments
Assignees

Comments

@buchanae
Copy link

In my karma.conf.js I have some mocha config, as described here:
https://github.com/karma-runner/karma-mocha

This line ends up overwriting that config:
https://github.com/karma-runner/grunt-karma/blob/master/tasks/grunt-karma.js#L23

Maybe karma should be merging instead of overwriting, but here's some history to that point:
karma-runner/karma#283

@vojtajina
Copy link
Contributor

I think grunt-karma should do a deep merge.

Override makes sense in the case of browsers, but not in the case of client. Even client.args should be deeply merged.

@roryf
Copy link

roryf commented Mar 12, 2014

This is breaking console.log since karma v0.11.10 due to this change karma-runner/karma@4734962

Setting client: { captureConsole: true } in my Gruntfile or adding --capture-console=true on command line fixes this, however it's not immediately obvious to me how to fix grunt-karma. Even if it does a deep merge of client, the problem is the defaults are being overridden, which suggests a bug in karma-runner.

@tardyp
Copy link

tardyp commented Mar 13, 2014

+1. I spend lot of time figuring out why console.log stopped working a while ago.

Also, the default client config: useIFrame is also overridden to undefined. I'm not sure of the impact

@dignifiedquire
Copy link
Member

Run into this today myself. I'll fix this tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants