refactor: replace .substring() with .slice()

.slice() is shorter and generally faster Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
karma-runner · Mar 27, 2022 · 1b6ded5 · 1b6ded5
1 parent d6359a7
commit 1b6ded5
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/lib/file.js b/lib/file.js
@@ -36,7 +36,7 @@ class File {
    * @returns {string} detected file type or empty string
    */
   detectType () {
-    return path.extname(this.path).substring(1)
+    return path.extname(this.path).slice(1)
   }
 
   toString () {

diff --git a/lib/helper.js b/lib/helper.js
@@ -30,15 +30,15 @@ const parser = (pattern, out) => {
       t = 'optional'
     }
     out[t]++
-    return parser(pattern.substring(1), out)
+    return parser(pattern.slice(1), out)
   }
   if (matches[2] !== undefined) {
     out.ext_glob++
     parser(matches[2], out)
-    return parser(pattern.substring(matches[0].length), out)
+    return parser(pattern.slice(matches[0].length), out)
   }
   out.range++
-  return parser(pattern.substring(matches[0].length), out)
+  return parser(pattern.slice(matches[0].length), out)
 }
 
 const gsParser = (pattern, out) => {

diff --git a/lib/launchers/process.js b/lib/launchers/process.js
@@ -44,7 +44,7 @@ function ProcessLauncher (spawn, tempDir, timer, processKillTimeout) {
   // Normalize the command, remove quotes (spawn does not like them).
   this._normalizeCommand = function (cmd) {
     if (cmd.charAt(0) === cmd.charAt(cmd.length - 1) && '\'`"'.includes(cmd.charAt(0))) {
-      cmd = cmd.substring(1, cmd.length - 1)
+      cmd = cmd.slice(1, -1)
       log.warn(`The path should not be quoted.\n  Normalized the path to ${cmd}`)
     }
 

diff --git a/lib/url.js b/lib/url.js
@@ -19,7 +19,7 @@ class Url {
    * @returns {string} detected file type or empty string
    */
   detectType () {
-    return path.extname(new URL(this.path).pathname).substring(1)
+    return path.extname(new URL(this.path).pathname).slice(1)
   }
 
   toString () {