Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: karma-runner/karma Loading
base: v6.3.1
Choose a base ref
...
head repository: karma-runner/karma Loading
compare: v6.3.2
Choose a head ref
  • 2 commits
  • 6 files changed
  • 2 contributors

Commits on Mar 29, 2021

  1. fix: fix running tests in IE9 (#3668) 

    So the symptom is that after Karma page is loaded in IE9 the tests don't run and Karma is stuck at the "starting" step. Reloading the page once or twice makes IE9 connect to the server and tests pass successfully.

After an "exciting" debugging session I figured out that the problem is that on the first load (and sometimes after the page reload) [`io` variable](https://github.com/karma-runner/karma/blob/026fff870913fb6cd2858dd962935dc74c92b725/client/main.js#L14), which should be set by the `socket.io.js` script is undefined. It looks like IE9 silently stops executing `socket.io.js` script somewhere midway and switches to the next script causing the `io` variable to be undefined. I assume it hits some limit or threshold or whatnot. Couldn't find much information on the Internet, besides people experiencing similar issues when loading e.g. unminified jQuery and their own code firing before the `$` variable is available. No good solutions found.

Checking the `socket.io.js` contents, I have noticed that v2 served the minified client script on that path, while v3 now serves the unminified code. Presumably the huge script size is what causing IE9 to choke. Switching back to the minified socket.io client bundle allows tests to pass in IE9.

With the fix, tests passed 5 times in a row, while without it they fail every time, so I assume it does resolve the problem.

Fixes #3665
    @devoto13
    devoto13 committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    0055bc5 View commit details
    Browse the repository at this point in the history

  2. chore(release): 6.3.2 [skip ci] 

    ## [6.3.2](v6.3.1...v6.3.2) (2021-03-29)

### Bug Fixes

* fix running tests in IE9 ([#3668](#3668)) ([0055bc5](0055bc5)), closes [/github.com/karma-runner/karma/blob/026fff870913fb6cd2858dd962935dc74c92b725/client/main.js#L14](https://github.com//github.com/karma-runner/karma/blob/026fff870913fb6cd2858dd962935dc74c92b725/client/main.js/issues/L14) [#3665](#3665)
    @semantic-release-bot
    semantic-release-bot committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    267b477 View commit details
    Browse the repository at this point in the history
Loading