-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding support for before middleware #2143
feat: adding support for before middleware #2143
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
Thanks for the contribution! Could you please add a set of tests that cover this to ensure this is doing what is expected. (e2e as well as unit tests) |
04f6c31
to
11f5fe2
Compare
@dignifiedquire I added tests similar tot he middleware tests that were existing -- is that sufficient? |
@dignifiedquire bump |
11f5fe2
to
51b4206
Compare
Rebased on master to resolve conflicts |
bump @dignifiedquire |
Thanks |
This adds a
beforeMiddleware
option to the config. This allows the user to inject middleware before karma's middleware are ran. My use case is blocking the tests on refresh while the tests are recompiling (to prevent old test files from being served).