Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding support for before middleware #2143

Merged

Conversation

ibash
Copy link
Contributor

@ibash ibash commented May 19, 2016

This adds a beforeMiddleware option to the config. This allows the user to inject middleware before karma's middleware are ran. My use case is blocking the tests on refresh while the tests are recompiling (to prevent old test files from being served).

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@ibash
Copy link
Contributor Author

ibash commented May 19, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@dignifiedquire
Copy link
Member

Thanks for the contribution! Could you please add a set of tests that cover this to ensure this is doing what is expected. (e2e as well as unit tests)

@ibash ibash force-pushed the feature-add-before-middleware branch from 04f6c31 to 11f5fe2 Compare May 20, 2016 19:55
@ibash
Copy link
Contributor Author

ibash commented May 20, 2016

@dignifiedquire I added tests similar tot he middleware tests that were existing -- is that sufficient?

@ibash
Copy link
Contributor Author

ibash commented May 27, 2016

@dignifiedquire bump

@ibash ibash force-pushed the feature-add-before-middleware branch from 11f5fe2 to 51b4206 Compare May 30, 2016 15:32
@ibash
Copy link
Contributor Author

ibash commented May 30, 2016

Rebased on master to resolve conflicts

@ibash
Copy link
Contributor Author

ibash commented Jun 10, 2016

bump @dignifiedquire

@dignifiedquire dignifiedquire merged commit ce9038f into karma-runner:master Jun 23, 2016
@dignifiedquire
Copy link
Member

Thanks :octocat:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants