feat(reporter): improve source map handling and reporting. #2149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zzo PTAL |
|
@mprobst thanks for PR Please look at failed tests - https://ci.appveyor.com/project/dignifiedquire/karma/build/296/job/0ukhlfgwcm548tjg |
mprobst
force-pushed
the
source-map-fixes
branch
2 times, most recently
from
8fed424
to
0dcdea4
Compare
- Avoid prepending basepath to every file path. The original path is usually relative to the project, and much more meaningful than basepath + path, which is usually a long, absolute path. - Format as [mapped location] <- [original location] The mapped location is the more important part for users, it's the source file they are working on. - Resolve source map file paths relative to the original file path. It's common for tools that generate a source map to not have a complete understanding of what paths they should generate, in which case they just use the local path. An example tool is TypeScript. Resolving the path against the original file path makes these paths unambiguous in the project.
|
@maksimr @dignifiedquire Thanks for looking into this! I fixed the test failure (grumble grumble windows grumble). |
|
thanks martin looks good |
|
Thanks |
sourcemaps can always use more love
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original path is usually relative to the project, and much more meaningful
than basepath + path, which is usually a long, absolute path.
The mapped location is the more important part for users, it's the source
file they are working on.
It's common for tools that generate a source map to not have a complete
understanding of what paths they should generate, in which case they just use
the local path. An example tool is TypeScript.
Resolving the path against the original file path makes these paths
unambiguous in the project.