Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(launcher): send sigkill on timeout when force killing #2169

Merged

Conversation

bkakadiya42
Copy link
Contributor

@bkakadiya42 bkakadiya42 commented Jun 10, 2016

@dignifiedquire This is in response to bug we are seeing where karma hangs because it is unable to force kill chrome, possibly #24 (comment)

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@bkakadiya42
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@bkakadiya42 bkakadiya42 changed the title bug: send sigkill on timeout when force killing fix(launcher): send sigkill on timeout when force killing Jun 10, 2016
@dignifiedquire
Copy link
Member

Thanks, can you change the commit message to befix(launcher: instead of bug please?

@bkakadiya42 bkakadiya42 force-pushed the send-sigkill-while-forcekilling branch from 272f7ae to c615c1f Compare June 14, 2016 21:15
@bkakadiya42
Copy link
Contributor Author

@dignifiedquire, i updated the commit message, thanks.

@avaer
Copy link

avaer commented Jun 21, 2016

@dignifiedquire Any ETA/version for this PR landing?

@dignifiedquire dignifiedquire merged commit ca1284e into karma-runner:master Jun 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants