Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): run client tests without grunt wrapper #3604

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

devoto13
Copy link
Collaborator

Notes:

  • Changed the Karma configuration file instead of passing CLI flags as was done in the removed custom Grunt task.
  • Removed unnecessary wrapper script for AppVeyor.

PS I'm debugging why unit tests fail without Grunt wrapper, will probably submit it as a separate PR tomorrow.

@karmarunnerbot
Copy link
Member

Build karma 425 failed (commit b71edf9391 by @devoto13)

@karmarunnerbot
Copy link
Member

Build karma 424 failed (commit b71edf9391 by @devoto13)

@karmarunnerbot
Copy link
Member

Build karma 434 failed (commit 0020eef9bd by @devoto13)

@karmarunnerbot
Copy link
Member

Build karma 433 failed (commit 0020eef9bd by @devoto13)

@karmarunnerbot
Copy link
Member

Build karma 435 completed (commit a168248176 by @devoto13)

@karmarunnerbot
Copy link
Member

Build karma 434 completed (commit a168248176 by @devoto13)

@johnjbarton johnjbarton merged commit 68c4a3a into karma-runner:master Jan 12, 2021
@devoto13 devoto13 deleted the cleanup-grunt-2 branch January 13, 2021 07:16
@karmarunnerbot
Copy link
Member

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants